-
Notifications
You must be signed in to change notification settings - Fork 201
feat: Horizontal variant of steps #3959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3959 +/- ##
=======================================
Coverage 97.17% 97.18%
=======================================
Files 857 857
Lines 25304 25330 +26
Branches 8983 9000 +17
=======================================
+ Hits 24590 24616 +26
Misses 708 708
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
498655c to
b3c1d9f
Compare
1b764f0 to
8d87555
Compare
8d87555 to
7cd702c
Compare
Well spotted! There's a two-part mitigation for this: 1) I've added some of our wrapping styles to prevent the overlapping from happening, 2) for now, this is Core-only layout and considered an atomic so we'll be expecting teams to build their own responsiveness (i.e., changing to a vertical layout); there will be guidelines for that. |
Makes sense |


Description
This change improves the flexibility of the steps component in Core with two features: 1) horizontal orientation, and 2) custom render step functions.
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.