Skip to content

Conversation

@timogasda
Copy link
Member

@timogasda timogasda commented Oct 22, 2025

Description

This change improves the flexibility of the steps component in Core with two features: 1) horizontal orientation, and 2) custom render step functions.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.18%. Comparing base (446fd0a) to head (a5bf1f8).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3959   +/-   ##
=======================================
  Coverage   97.17%   97.18%           
=======================================
  Files         857      857           
  Lines       25304    25330   +26     
  Branches     8983     9000   +17     
=======================================
+ Hits        24590    24616   +26     
  Misses        708      708           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

NathanZlion
NathanZlion previously approved these changes Oct 24, 2025
Copy link
Member

@NathanZlion NathanZlion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@NathanZlion
Copy link
Member

I've just identified an issue when viewing the horizontal variant in a small width screen. When viewing on mobile devices, the demo content appears to be compressed, causing elements to overlap each other as shown in the screenshots below:

image image

Is this something that we can avoid from the component level, perhaps by making the component not shrink below a certain width? or is it an expected behavior?

@timogasda
Copy link
Member Author

I've just identified an issue when viewing the horizontal variant in a small width screen. When viewing on mobile devices, the demo content appears to be compressed, causing elements to overlap each other as shown in the screenshots below:

Well spotted! There's a two-part mitigation for this: 1) I've added some of our wrapping styles to prevent the overlapping from happening, 2) for now, this is Core-only layout and considered an atomic so we'll be expecting teams to build their own responsiveness (i.e., changing to a vertical layout); there will be guidelines for that.

@timogasda timogasda requested a review from NathanZlion October 29, 2025 10:34
@NathanZlion
Copy link
Member

  1. for now, this is Core-only layout and considered an atomic so we'll be expecting teams to build their own responsiveness (i.e., changing to a vertical layout); there will be guidelines for that.

Makes sense

@timogasda timogasda added this pull request to the merge queue Oct 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2025
@timogasda timogasda added this pull request to the merge queue Oct 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2025
@timogasda timogasda added this pull request to the merge queue Oct 30, 2025
Merged via the queue into main with commit da2f215 Oct 30, 2025
49 checks passed
@timogasda timogasda deleted the gasda/core-steps branch October 30, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants